-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2113-W12-4] Fit Track #13
base: master
Are you sure you want to change the base?
[CS2113-W12-4] Fit Track #13
Conversation
…endar Jingxi-Calendar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, class diagrams can be included as well
docs/DeveloperGuide.md
Outdated
|
||
<div markdown="span" class="alert alert-primary"> | ||
|
||
:bulb: **Tip:** The '.puml' files used to create the diagrams in this document can be found in [diagrams](./diagrams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The :bulb is not showing up correctly
docs/DeveloperGuide.md
Outdated
* [**`WorkoutList`**](#workout-list-component): Stores all workouts. | ||
* [**`Parser`**](#parser-component): Handles user input. | ||
* [**`Data`**](#data-component): Holds the data of the app in memory. | ||
* [**`Command`**](#command-component): The command executor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links do not work on the website
docs/DeveloperGuide.md
Outdated
### Core sequence | ||
Core sequence of code is written in [`FitTrack`](../src/main/java/fittrack/FitTrack.java) class. | ||
|
||
![Core structure](images/FitTrackOuter.svg "Outer Structure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to remove the bottom object names with hide footbox
docs/DeveloperGuide.md
Outdated
|
||
![Core structure](images/FitTrackOuter.svg "Outer Structure") | ||
|
||
![Inner structure](images/FitTrackCore.svg "Core Structure") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Core Structure, is "do-while" supposed to be "loop" instead?
![Structure of Storage Load](images/StorageLoad.svg) | ||
The sequence diagram of the code for loading the file contents into each class. | ||
|
||
![Structure of Storage Save](images/StorageSave.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Main Structure of Storage Save, the :FIleWriter on the right is hard to read, maybe choose a different colour?
docs/DeveloperGuide.md
Outdated
|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list| | ||
|Version| As a ... | I want to ... | So that I can ... | | ||
|--------|----------|-------------------------------------------------------------|---------------------------------------------------------------| | ||
|v1.0|new user| know how to use the product | use the product | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the user comments more specific for the things that you want to implement. For example, a user knowing how to run your application doesn't really say much about what needs to be changed or updated
docs/DeveloperGuide.md
Outdated
|
||
|
||
### Architecture | ||
{insert diagram to show architecture of code} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure if I just missed it or its a work in progress but I didn't see the diagram in the initial DG
|
||
### Value proposition | ||
|
||
{Describe the value proposition: what problem does it solve?} | ||
Fittrack is a health management application which allows users to record their diet and activity, and help them to reach the goal they have set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good value proposition, straight to the point
docs/DeveloperGuide.md
Outdated
|v2.0|user| see the total calories I have burnt on a particular date | track my daily calories burnt | | ||
|v2.0|user| find a meal or workout | quickly search my past meals or workouts | | ||
|
||
|
||
|
||
## Non-Functional Requirements | ||
|
||
{Give non-functional requirements} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be a diagram or are there no non-functional requirements?
|
||
main -> main ++: loopCommandExecution() | ||
|
||
group do-while [!ExitCommand.isExit(command)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this representation of loop also acceptable? In our textbook the usual representation is "loop"
docs/DeveloperGuide.md
Outdated
|
||
<div markdown="span" class="alert alert-primary"> | ||
|
||
:bulb: **Tip:** The '.puml' files used to create the diagrams in this document can be found in [diagrams](./diagrams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to diagrams folder is not working
main -> ui ++: ui.printCR(commandResult: CR) | ||
note left: Print the result of execution | ||
note right: CR for CommandResult | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sequence diagram is generally clear and easy to read!
participant ":WorkoutListDecoder" as wDecoder STORAGE_COLOR_T3 | ||
|
||
main -> main ++: start() | ||
activate main MODEL_COLOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the colored representation. It allows readers to differentiate each class more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
docs/images/FitTrackCore.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/images/FitTrackCore.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/images/StorageSave.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify codes and UG
Fix profile loading bug
Add sequence diagrams
Resolves #60
Update UG
Update DG
Update DG PPP
Update AboutUs.md
# Conflicts: # docs/DeveloperGuide.md
Update DG Final
Update PPP
Update PPP for Nixon
FitTrack allows users to track meals and workouts, helping them to adjust their diet and exercise to lead a healthy lifestyle. It is optimised for CLI users so that tracking can be done efficiently and easily by typing in commands.